fix: resolve duplicate commit field and add commitId filter test
- Replace spread operator with explicit field selection to avoid duplicate commit field from getApks() and parseApkFilename() - Add test case for commitId parameter filtering to ensure the filter parameter works correctly with new metadata extraction Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -70,4 +70,52 @@ describe('/api/apks', () => {
|
|||||||
expect(response.status).toBe(500);
|
expect(response.status).toBe(500);
|
||||||
expect(data.error).toBe('Failed to fetch APK files');
|
expect(data.error).toBe('Failed to fetch APK files');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('should filter APKs by commitId parameter', async () => {
|
||||||
|
const mockApks = [
|
||||||
|
{
|
||||||
|
name: 'ft_timeshift_0_42_57ef3a60d.apk',
|
||||||
|
size: 15728640,
|
||||||
|
modifiedAt: new Date('2026-03-04T14:30:00Z'),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: 'ft_0_42_ff9ff3441.apk',
|
||||||
|
size: 15728640,
|
||||||
|
modifiedAt: new Date('2026-03-04T14:30:00Z'),
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: 'ft_0_42_abc1234.apk',
|
||||||
|
size: 15728640,
|
||||||
|
modifiedAt: new Date('2026-03-04T14:30:00Z'),
|
||||||
|
},
|
||||||
|
];
|
||||||
|
|
||||||
|
const filteredApks = [
|
||||||
|
mockApks[1],
|
||||||
|
];
|
||||||
|
|
||||||
|
(getApks as jest.Mock).mockImplementation((project, version, commitId) => {
|
||||||
|
if (commitId === 'ff9ff3441') {
|
||||||
|
return Promise.resolve(filteredApks);
|
||||||
|
}
|
||||||
|
return Promise.resolve(mockApks);
|
||||||
|
});
|
||||||
|
|
||||||
|
(parseApkFilename as jest.Mock)
|
||||||
|
.mockReturnValue({ environment: 'product', commit: 'ff9ff3441', isValid: true });
|
||||||
|
|
||||||
|
const request = new Request('http://localhost:3000/api/apks?project=FT&version=0_42&commit=ff9ff3441');
|
||||||
|
const response = await GET(request);
|
||||||
|
const data = await response.json();
|
||||||
|
|
||||||
|
expect(response.status).toBe(200);
|
||||||
|
expect(data).toHaveLength(1);
|
||||||
|
expect(data[0]).toMatchObject({
|
||||||
|
name: 'ft_0_42_ff9ff3441.apk',
|
||||||
|
environment: 'product',
|
||||||
|
commit: 'ff9ff3441',
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(getApks).toHaveBeenCalledWith('FT', '0_42', 'ff9ff3441');
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -21,7 +21,8 @@ export async function GET(request: Request) {
|
|||||||
const apksWithMetadata = apks.map(apk => {
|
const apksWithMetadata = apks.map(apk => {
|
||||||
const parsed = parseApkFilename(apk.name);
|
const parsed = parseApkFilename(apk.name);
|
||||||
return {
|
return {
|
||||||
...apk,
|
name: apk.name,
|
||||||
|
size: apk.size,
|
||||||
environment: parsed.environment,
|
environment: parsed.environment,
|
||||||
commit: parsed.commit,
|
commit: parsed.commit,
|
||||||
modifiedAt: apk.modifiedAt.toISOString(),
|
modifiedAt: apk.modifiedAt.toISOString(),
|
||||||
|
|||||||
Reference in New Issue
Block a user