fix: use streaming and add path validation

- Replace fs.readFileSync() with fs.createReadStream() to prevent memory exhaustion
- Export validatePath() from fs-utils.ts
- Use validatePath() to validate full path including project and version parameters
- Fix incomplete path traversal protection
- Add filename encoding in Content-Disposition header

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This commit is contained in:
2026-03-04 02:01:38 +08:00
parent 7d5ee36f56
commit cf7d3d5618
2 changed files with 11 additions and 17 deletions

View File

@@ -1,8 +1,8 @@
// app/api/download/route.ts // app/api/download/route.ts
import { NextResponse } from 'next/server'; import { NextResponse } from 'next/server';
import path from 'path';
import fs from 'fs'; import fs from 'fs';
import { RESOURCE_PATH } from '@/lib/constants'; import { RESOURCE_PATH } from '@/lib/constants';
import { validatePath } from '@/lib/fs-utils';
export async function GET(request: Request) { export async function GET(request: Request) {
const { searchParams } = new URL(request.url); const { searchParams } = new URL(request.url);
@@ -17,18 +17,11 @@ export async function GET(request: Request) {
); );
} }
// 安全检查:确保 filename 不包含路径遍历字符 // Validate the full path to prevent path traversal attacks
if (filename.includes('..') || filename.includes('/') || filename.includes('\\')) { const filePath = validatePath(RESOURCE_PATH, project, version, 'apks', filename);
return NextResponse.json(
{ error: 'Invalid filename' },
{ status: 400 }
);
}
const filePath = path.join(RESOURCE_PATH, project, version, 'apks', filename);
try { try {
// 检查文件是否存在 // Check if file exists
if (!fs.existsSync(filePath)) { if (!fs.existsSync(filePath)) {
return NextResponse.json( return NextResponse.json(
{ error: 'File not found' }, { error: 'File not found' },
@@ -36,14 +29,15 @@ export async function GET(request: Request) {
); );
} }
// 读取文件并流式返回 // Use streaming to avoid loading entire file into memory
const file = fs.readFileSync(filePath); const fileStream = fs.createReadStream(filePath);
const stat = await fs.promises.stat(filePath);
return new NextResponse(file, { return new NextResponse(fileStream as any, {
headers: { headers: {
'Content-Type': 'application/vnd.android.package-archive', 'Content-Type': 'application/vnd.android.package-archive',
'Content-Disposition': `attachment; filename="${filename}"`, 'Content-Disposition': `attachment; filename="${encodeURIComponent(filename)}"`,
'Content-Length': file.length.toString(), 'Content-Length': stat.size.toString(),
}, },
}); });
} catch (error) { } catch (error) {

View File

@@ -6,7 +6,7 @@ import { RESOURCE_PATH } from './constants';
/** /**
* Validate that a path doesn't escape the base directory (prevents path traversal) * Validate that a path doesn't escape the base directory (prevents path traversal)
*/ */
function validatePath(basePath: string, ...segments: string[]): string { export function validatePath(basePath: string, ...segments: string[]): string {
const fullPath = path.resolve(basePath, ...segments); const fullPath = path.resolve(basePath, ...segments);
const normalizedBase = path.resolve(basePath); const normalizedBase = path.resolve(basePath);
if (!fullPath.startsWith(normalizedBase)) { if (!fullPath.startsWith(normalizedBase)) {